Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Make color matrix filter work as expected #35926

Merged
auto-submit merged 3 commits into from
Sep 7, 2022
Merged

[Impeller] Make color matrix filter work as expected #35926

auto-submit merged 3 commits into from
Sep 7, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Sep 5, 2022 •
edited
Loading

fix flutter/flutter#111012

Color matrix

    FilterContents::ColorMatrix matrix = {
        0, 0, 0, 0, 0,  //
        1, 0, 0, 0, 0,  //
        0, 0, 0, 0, 0,  //
        0, 0, 0, 1, 0,  //
    };

before fix

8gILVDAZUI

after fix

sKfZll9Amm

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 5, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ColdPaleLight ColdPaleLight marked this pull request as draft September 5, 2022 13:26
@ColdPaleLight ColdPaleLight self-assigned this Sep 5, 2022
@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented Sep 6, 2022

(Test added)

@ColdPaleLight ColdPaleLight marked this pull request as ready for review September 6, 2022 02:59
bdero
bdero approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bdero
bdero reviewed Sep 6, 2022
View reviewed changes
impeller/entity/entity_unittests.cc Outdated
ASSERT_TRUE(OpenPlaygroundHere(callback));
}

TEST_P(EntityTest, ColorMatrixFilterOnlyShowGreen) {
Copy link
Member

@bdero bdero Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth just dropping this playground since there are already other manual verification playgrounds for this filter.

Copy link
Member

@bdero bdero Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think the ColorMatrixFilter playground above this one should also be deleted, since ColorMatrixFilterEditable does the same thing but with more interactivity)

Copy link
Member Author

@ColdPaleLight ColdPaleLight Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ColdPaleLight ColdPaleLight added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 6, 2022
@auto-submit auto-submit bot merged commit 20f70d4 into flutter:main Sep 7, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
20f70d4 [Impeller] Make color matrix filter work as expected (flutter…
9a7fed5 
…/engine#35926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
20f70d4 [Impeller] Make color matrix filter work as expected (flutter…
7d44213 
…/engine#35926)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
20f70d4 [Impeller] Make color matrix filter work as expected (flutter…
68ca98c 
…/engine#35926)
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@ColdPaleLight
[Impeller] Make color matrix filter work as expected (flutter#35926)
5e40f73
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@bdero bdero bdero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ColdPaleLight ColdPaleLight

Labels

autosubmit Merge PR when tree becomes green via auto submit App e: impeller

Projects

No open projects
Impeller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Impeller] color matrix filter doesn't work correctly

2 participants

@ColdPaleLight @bdero