Started handling messages from background isolates for Android #35804
Conversation
bfa8301 to
7762c1f
Compare
7762c1f to
399240f
Compare
|
@dnfield there isn't much code that is changed here, mostly comments and turning one integer atomic. If you want me to walk through why this is safe let me know. I've added comments to where the threading policy is changing so you can read through to make sure it's safe. My testing plan is to rely on the integration tests in the framework PR. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Integration tests are in the framework PR. |
| HandlerInfo handlerInfo; | ||
| boolean messageDeferred; | ||
| // TODO(gaaclarke): This can potentially be a bottleneck and could replaced | ||
| // with a read/write lock. |
There was a problem hiding this comment.
I switched it to a regular comment if you don't mind. I'm not sure I want to commit to the idea that it is something we need to do, but I don't want to lose the idea that it was something we could do.
There was a problem hiding this comment.
I think it'd be fine to file a bug either way to add a benchmark for this and figure out if/how much a different lock would help. But non-blocking for landing this.
There was a problem hiding this comment.
This provides all the work for handling platform channels in the Dart->Host direction for Android. For more details and integration tests see the framework PR.
Integration tests exist in the framework PR.
companion framework PR: flutter/flutter#111279
companion engine PR (iOS): #35174
issue: flutter/flutter#13937
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.