[fuchsia] Convert integration test to CFv2 #35318
Conversation
c707fd4 to
795917e
Compare
|
This will pass once https://fuchsia-review.googlesource.com/c/fuchsia/+/710565 and https://fuchsia-review.googlesource.com/c/fuchsia/+/710235 land and roll PTAL for now, disregarding compilation errors on the bots. Will land once SDK contains the FIDLs |
|
|
||
| ```shell | ||
| $ cd "$FUCHSIA_DIR" | ||
| $ fx set terminal.x64 |
There was a problem hiding this comment.
jw why terminal instead of workstation_eng? I think Fuchsia is trying to converge on workstation being the image for OOT testing in the longer-term.
There was a problem hiding this comment.
I used that b/c the Flutter CQ bot currently uses terminal. When we switch the flutter CQ to use workstation_eng we could update this to match. Do you have a bug I can reference in a TODO here?
(Ran the tests locally against workstation_eng and they passed there too FWIW)
| $ fx build | ||
| ``` | ||
|
|
||
| ## Build the test |
There was a problem hiding this comment.
I might be wrong but it feels like the build and run test parts could be encapsulated in a build_and_run_test.sh script that takes the name of the integration test folder to run. There might be a switch statement that chooses what package names to publish based on the name of the integration test folder, but besides that it feels the same from test to test.
It feels like it would be a more convenient workflow to do something like:
$ENGINE_DIR/tools/fuchsia/devshell/build_and_run_test.sh flutter-embedder-test
And have it build, publish everything we need and then run the test.
There was a problem hiding this comment.
Will write this and update instructions
There was a problem hiding this comment.
FWIW I did not get a chance to write this @akbiggs Can we file a bug and push a follow-up CL for it?
shell/platform/fuchsia/flutter/tests/integration/embedder/child-view/lib/child_view.dart
Show resolved
Hide resolved
shell/platform/fuchsia/flutter/tests/integration/embedder/child-view/lib/child_view.dart
Show resolved
Hide resolved
795917e to
adbde89
Compare
adbde89 to
31601bf
Compare
31601bf to
bc18d8f
Compare
Migrate the integration test to CFv2 via using the "Test UI Stack". Eliminates the implicit, unversioned deps between the test and UI package names+routes.
Fixes: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=101032