This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Shut down VM on shutdown of last engine #35251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Flutter engines in the same process share a common Dart VM, which is launched with the start of the first engine in the process and should be terminated when the last engine in the process has been deallocated. Formerly, it was not possible to cleanly shut down and restart the VM in a process, but this was resolved in the Dart SDK and a flag exposed in #10652. Since some embedders take advantage of the fact that the VM remains running after engine shutdown, this flag is not enabled by default, however it should be enabled for the Windows embedder, which we control. No tests added since this is not testable via any API to which the Windows embedder has access. The behaviour of this flag is tested in the embedder API tests in `EmbedderTest.VMShutsDownWhenNoEnginesInProcess` in shell/platform/embedder/tests/embedder_unittests.cc. Issue: flutter/flutter#109191
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: optimization |
yaakovschectman
approved these changes
Aug 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2022
emilyabest
pushed a commit
to emilyabest/engine
that referenced
this pull request
Aug 12, 2022
All Flutter engines in the same process share a common Dart VM, which is launched with the start of the first engine in the process and should be terminated when the last engine in the process has been deallocated. Formerly, it was not possible to cleanly shut down and restart the VM in a process, but this was resolved in the Dart SDK and a flag exposed in flutter#10652. Since some embedders take advantage of the fact that the VM remains running after engine shutdown, this flag is not enabled by default, however it should be enabled for the Windows embedder, which we control. No tests added since this is not testable via any API to which the Windows embedder has access. The behaviour of this flag is tested in the embedder API tests in `EmbedderTest.VMShutsDownWhenNoEnginesInProcess` in shell/platform/embedder/tests/embedder_unittests.cc. Issue: flutter/flutter#109191
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Flutter engines in the same process share a common Dart VM, which is
launched with the start of the first engine in the process and should be
terminated when the last engine in the process has been deallocated.
Formerly, it was not possible to cleanly shut down and restart the VM in
a process, but this was resolved in the Dart SDK and a flag exposed in
#10652. Since some custom embedders may take advantage of
the fact that the VM remains running after engine shutdown, this flag is
not enabled by default, however it should be enabled for the Windows
embedder, which we control.
No tests added since this is not testable via any API to which the
Windows embedder has access. The behaviour of this flag is tested in the
embedder API tests in
EmbedderTest.VMShutsDownWhenNoEnginesInProcessin shell/platform/embedder/tests/embedder_unittests.cc.
Issue: flutter/flutter#109191
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.