Eliminate redundant Win32 suffix in Windows embedder #34983
Conversation
Now that we've removed the UWP embedder, eliminate remaining Win32 suffixes on identifiers and _win32 suffixes from filenames. Issue: flutter/flutter#108386
| } | ||
|
|
||
| void FlutterWindowsEngine::UpdateSemanticsEnabled(bool enabled) { | ||
| using AccessibilityBridgeDelegateWindows = AccessibilityBridgeDelegateWin32; |
There was a problem hiding this comment.
I should probably have cleaned this up when I deleted the #ifdef'ed Win32/UWP; no longer necessary either way.
|
The licence script will fail; I'll push an update for that once that happens :) |
| namespace flutter { | ||
|
|
||
| // A win32 flutter child window used as implementations for flutter view. In | ||
| // the future, there will likely be a CoreWindow-based FlutterWindow as well. |
There was a problem hiding this comment.
CoreWindow is UWP, right? This comment seems stale, should we delete it?
| #include "flutter/shell/platform/windows/event_watcher.h" | ||
|
|
||
| namespace flutter { | ||
|
|
There was a problem hiding this comment.
Should this type & file be renamed as well?
|
For my own knowledge (feel free to punt this for later!), should these files be updated as well? Or are their win32 suffixes not redundant for some reason?
|
Those need to be done, but will be done in separate one-by-one PRs since they don't fall into the "files and types ending in _win32/Win32 that don't require further rework/merging/simplification" in this PR. Sorry for not calling that out more explicitly in the PR description. I'll edit comment to clarify in the merge. |
|
Gotcha that makes sense! :) |
Now that we've removed the UWP embedder, eliminate remaining Win32 suffixes on identifiers and _win32 suffixes from filenames. This renames all files and types ending in _win32/Win32 that don't require further rework/merging/simplification. All remaining files/types ending in _win32/Win32 are less straightforward and will be submitted class by class. Issue: flutter/flutter#108386
Eliminate Win32 suffixes in Windows embedder
Now that we've removed the UWP embedder, eliminate remaining Win32
suffixes on identifiers and _win32 suffixes from filenames.
This renames all files and types ending in _win32/Win32 that don't
require further rework/merging/simplification.
No additional tests since this is a renaming only with no semantic change.
Issue: flutter/flutter#108386
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.