Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 19, 2022

Drops all @dart annotations >= 2.12.

These are remnants of the null safety incremental migration.

There are still a few libraries in the engine that have < 2.12 - some are in //shell/platform/fuchsia, and two others are in the benchmark uploading script and the verify_exported_symbols package - those will require null safety migration.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green.

Do we have issues filed for the code that needs to be null-safety-migrated?

@dnfield
Copy link
Contributor Author

dnfield commented Jul 19, 2022

Updated flutter/flutter#71507 with remaining locations

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 19, 2022

  • The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2022
@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2022
@auto-submit auto-submit bot merged commit afbd1ae into flutter:main Jul 19, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants