Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[fuchsia][scenic] Move pointer injector to embedder. #34555

Merged
shivesh-ganju merged 1 commit into from
Jul 12, 2022
Merged

[fuchsia][scenic] Move pointer injector to embedder. #34555

shivesh-ganju merged 1 commit into from
Jul 12, 2022

Conversation

@shivesh-ganju
Copy link
Contributor

@shivesh-ganju shivesh-ganju commented Jul 8, 2022

This PR moves the pointer injector library from fuchsia views library
present in fuchsia.git to the flutter embedder.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"

@akbiggs akbiggs self-requested a review July 8, 2022 22:39
@arbreng arbreng requested review from arbreng and jaeheon July 8, 2022 23:10
arbreng
arbreng reviewed Jul 8, 2022
View reviewed changes
@shivesh-ganju shivesh-ganju force-pushed the flutter_view_lib_4 branch 4 times, most recently from e6adf5e to c0e4ef1 Compare July 9, 2022 20:06
@shivesh-ganju shivesh-ganju requested a review from arbreng July 11, 2022 16:13
arbreng
arbreng approved these changes Jul 11, 2022
View reviewed changes
@shivesh-ganju
[fuchsia][scenic] Move pointer injector to embedder.
790e2e7 
This PR moves the pointer injector library from fuchsia views library
present in fuchsia.git to the flutter embedder.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
@shivesh-ganju shivesh-ganju merged commit 106c7e5 into flutter:main Jul 12, 2022
emilyabest pushed a commit to emilyabest/engine that referenced this pull request Jul 12, 2022
@shivesh-ganju @emilyabest
[fuchsia][scenic] Move pointer injector to embedder. (flutter#34555)
ce998f7 
This PR moves the pointer injector library from fuchsia views library
present in fuchsia.git to the flutter embedder.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
c895fab 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 12, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
6247f6d 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
3806c59 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
85a92a9 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
f6ad6a7 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
65ff5e5 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
7d4920e 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
13baf47 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
dd20580 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
fb274c5 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
304e147 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
0386d75 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
5f383f9 
…/engine#34555)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 13, 2022
@engine-flutter-autoroll
106c7e5 [fuchsia][scenic] Move pointer injector to embedder. (flutter…
fe23687 
…/engine#34555)
akbiggs added a commit that referenced this pull request Jul 14, 2022
@akbiggs
Revert "[fuchsia][scenic] Move pointer injector to embedder. (#34555)"
c57f803 
This reverts commit 106c7e5.
@akbiggs akbiggs mentioned this pull request Jul 14, 2022
Merged
akbiggs added a commit that referenced this pull request Jul 14, 2022
@akbiggs
Revert "[fuchsia][scenic] Move pointer injector to embedder. (#34555)" (
38f51b9 
#34661)

This reverts commit 106c7e5.
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 15, 2022
@shivesh-ganju @betrevisan
[fuchsia][scenic] Move pointer injector to embedder. (flutter#34555)
50b820b 
This PR moves the pointer injector library from fuchsia views library
present in fuchsia.git to the flutter embedder.

Test: ffx test run "fuchsia-pkg://fuchsia.com/flutter_runner_tests#meta/flutter_runner_tests.cm"
betrevisan pushed a commit to betrevisan/engine that referenced this pull request Jul 15, 2022
@akbiggs @betrevisan
Revert "[fuchsia][scenic] Move pointer injector to embedder. (flutter…
4f6fb72 
…#34555)" (flutter#34661)

This reverts commit 106c7e5.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akbiggs akbiggs Awaiting requested review from akbiggs

@jaeheon jaeheon Awaiting requested review from jaeheon

1 more reviewer

@arbreng arbreng arbreng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-fuchsia

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivesh-ganju @arbreng