Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix tests on the Windows platform #34350

Merged
loic-sharma merged 16 commits into from
Jul 11, 2022
Merged

Fix tests on the Windows platform #34350

loic-sharma merged 16 commits into from
Jul 11, 2022

Conversation

@mtolmacs
Copy link
Contributor

@mtolmacs mtolmacs commented Jun 28, 2022 •
edited
Loading

The aim of this PR is to allow successfully running all non-disabled dart and engine tests on local Windows, so engine development can happen on Windows machines proper.

Issues fixed by this PR

Changes to flutter/tests

This PR does not affect flutter/tests

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

mtolmacs added 2 commits June 28, 2022 11:36
@mtolmacs
Fixing (almost) all tests on Windows
e4255b2 
and removing feature gate on tests for Windows
@mtolmacs
Fixing incorrect merge duplicating
f18a07d 
the std::fstream::binary flag
@mtolmacs mtolmacs mentioned this pull request Jun 28, 2022
Closed
@skia-gold
Copy link

skia-gold commented Jun 28, 2022

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/34350

@mtolmacs
Adding missing COM initialization to
3150920 
flutter_tester on Windows
@skia-gold
Copy link

skia-gold commented Jun 28, 2022

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/34350

@skia-gold
Copy link

skia-gold commented Jun 28, 2022

Gold has detected about 1 new digest(s) on patchset 4.
View them at https://flutter-engine-gold.skia.org/cl/github/34350

loic-sharma
loic-sharma reviewed Jun 28, 2022
View reviewed changes
mtolmacs added 3 commits June 29, 2022 12:37
@mtolmacs
Reverting CoInitializeEx from tester_main.cc
462869d 
where it did not solve the issue the original commit
tries to fix
@mtolmacs
Fixing clang_tidy_test issues on Windows
0c311ae
@mtolmacs
Attempting to initialize COM on Windows
7f7becf 
before loading the platform image decoders
@skia-gold
Copy link

skia-gold commented Jun 29, 2022

Gold has detected about 1 new digest(s) on patchset 8.
View them at https://flutter-engine-gold.skia.org/cl/github/34350

@mtolmacs mtolmacs marked this pull request as ready for review June 29, 2022 13:45
chinmaygarde
chinmaygarde reviewed Jun 30, 2022
View reviewed changes
loic-sharma
loic-sharma reviewed Jul 7, 2022
View reviewed changes
@mtolmacs @loic-sharma
Update shell/testing/tester_main.cc
7d6d0a8 
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
loic-sharma
loic-sharma approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for your contribution, this is awesome ❤️

justinmc
justinmc approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm no Windows expert but I see no problems with this. It's great that we'll be able to run these locally now.

@skia-gold
Copy link

skia-gold commented Jul 9, 2022

Gold has detected about 1 new digest(s) on patchset 16.
View them at https://flutter-engine-gold.skia.org/cl/github/34350

@loic-sharma loic-sharma merged commit 50ee36a into flutter:main Jul 11, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 11, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 11, 2022
@engine-flutter-autoroll
50ee36a Fix tests on the Windows platform (flutter/engine#34350)
30e51f3
@mtolmacs mtolmacs deleted the windows-fix-tests branch July 14, 2022 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

2 more reviewers

@justinmc justinmc justinmc approved these changes

@loic-sharma loic-sharma loic-sharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtolmacs @skia-gold @chinmaygarde @justinmc @loic-sharma