-
Notifications
You must be signed in to change notification settings - Fork 6k
Expose a iOS plist setting to disable partial repaint. #34328
Conversation
If the following is added to Info.plist of the application, it will disable partial repaint: ``` <key>FLTDisablePartialRepaint</key> <true/> ``` The primary intended usecase for this is to enable applications to see if disabling partial repaint resolves: flutter/flutter#100522.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I think since this is just a temporary flag to help with debugging flutter/flutter#100522, this is okay, but in general a flag like this should be parsed along with the others in |
chinmaygarde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just make this go through flutter::Settings? I am not sure if this should be limited to just iOS. Also, to test just the flag setter, see testEnableImpellerSettingIsCorrectlyParsed.
|
hey @chinmaygarde , couple of things:
If this does indeed resolve the issue, I think we should think about a more long-term fix, maybe consider disabling DRM for all devices, or maybe focus a more involved effort in root-causing issues with DRM on iOS devices, but I'd really like to revert this if it doesn't prove to be a fix long term. Let me know if you disagree. |
|
Sound good! I LGTM'ed already. |
If the following is added to Info.plist of the application, it will disable partial repaint: ``` <key>FLTDisablePartialRepaint</key> <true/> ``` The primary intended usecase for this is to enable applications to see if disabling partial repaint resolves: flutter/flutter#100522.
If the following is added to Info.plist of the application, it will disable partial repaint:
The primary intended use case for this is to enable applications to see if disabling partial repaint helps: flutter/flutter#100522.