Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use darwin instead of mac for artifacts location. #34145

Merged
fluttergithubbot merged 2 commits into from
Jun 17, 2022
Merged

Use darwin instead of mac for artifacts location. #34145

fluttergithubbot merged 2 commits into from
Jun 17, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Jun 17, 2022

Flutter tool expects the artifacts in a darwin folder rather than mac.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Use darwin instead of mac for artifacts location.
d84c023 
Flutter tool expects the artifacts in a darwin folder rather than mac.

Bug: flutter/flutter#81855
christopherfujino
christopherfujino approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 17, 2022
@fluttergithubbot fluttergithubbot merged commit b6879d1 into flutter:main Jun 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2022
@engine-flutter-autoroll
b6879d1 Use darwin instead of mac for artifacts location. (flutter/en…
d48c5a9 
…gine#34145)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@godofredoc @houhuayong
Use darwin instead of mac for artifacts location. (flutter#34145)
27d36d9
@godofredoc godofredoc deleted the fix_mac_host_eng branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @christopherfujino @fluttergithubbot