Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Keyboard] Update generated key codes #34125

Merged
dkwingsmt merged 4 commits into from
Jun 22, 2022
Merged

[Keyboard] Update generated key codes #34125

dkwingsmt merged 4 commits into from
Jun 22, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jun 17, 2022 •
edited
Loading

This PR updates generated key codes in accordance with the following PRs:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-web Code specifically for the web engine platform-windows labels Jun 17, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 17, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dkwingsmt dkwingsmt requested a review from gspencergoog June 17, 2022 01:19
gspencergoog
gspencergoog approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt merged commit 8617929 into flutter:main Jun 22, 2022
@dkwingsmt dkwingsmt deleted the update-key-codes branch June 22, 2022 01:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2022
@engine-flutter-autoroll
8617929 [Keyboard] Update generated key codes (flutter/engine#34125)
cbdf7d8
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests platform-web Code specifically for the web engine platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkwingsmt @gspencergoog