Use std::filesystem to compute output paths in blobcat and impellerc #33939
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Not sure what we'd use to test this. Ideally we could "just" run the final binary? |
fml/platform/win/file_win.cc
Outdated
|
|
||
| if (!temp_file.is_valid()) { | ||
| FML_DLOG(ERROR) << "Could not create temporary file."; | ||
| FML_DLOG(ERROR) << "Could not create temporary file: " |
There was a problem hiding this comment.
A little confusing, but I think it's not the file that is temporary, but rather the file handle variable, so I think 'temporary' can be omitted from the error text.
Fixes flutter/flutter#105709