[web] Restore terminal's echo setting after felt quits #33928
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| io.stdin.echoMode = false; | ||
| io.stdin.lineMode = false; | ||
|
|
||
| // Reset these settings when the felt command is done. | ||
| cleanupCallbacks.add(() async { | ||
| io.stdin.echoMode = true; | ||
| io.stdin.lineMode = true; | ||
| }); |
There was a problem hiding this comment.
I like that the restoration is scheduled immediately after the values have been changed!
We are starting to see this issue in the engine when using the
felttool.This PR restores the terminal's echo setting similar to how the flutter tool does.