[fuchsia] Stop unimplemented TextInput from log spamming. #33811
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Requesting test exemption since the only observable behavior currently is logging which I don't think we should test against. |
|
@filmil @sanjayc77 FYI |
|
LGTM |
|
In general we do want to test that there is no log spam, so if there's a way to verify that it would be good to do so. |
|
"We have many tests in general that verify that the output is free of log spam for many specific cases, FWIW." Sorry @Hixie I'm having trouble finding these tests. :( Do you have an example I can follow? |
|
I think mostly they're in flutter/flutter, especially tool tests. But in general anywhere you have a test that can generate log spam, it's usually relatively easy to filter the logs through some code that can then check that only acceptable lines are being output. |
|
Can we land this? |
We see a lot of complaints about log spam related to this specific platform message, and we haven't implemented it for a while, so I'm turning off this specific error for now.
|
I can't come up with a strategy to test this so I'm going to land it. I accept that the spammy logs may reappear in the future. |
We see a lot of complaints about log
spam related to this specific platform
message, and we haven't implemented it for a while,
so I'm turning off this specific error for
now.