Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[embedder] Fix typo in EmbedderA11yTest #33120

Merged
fluttergithubbot merged 1 commit into from
May 5, 2022
Merged

[embedder] Fix typo in EmbedderA11yTest #33120

fluttergithubbot merged 1 commit into from
May 5, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 4, 2022

We were missing the 'A' in Accessibility.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken cbracken requested review from goderbauer and loic-sharma May 4, 2022 23:17
@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label May 4, 2022
@cbracken
Copy link
Member Author

cbracken commented May 4, 2022

Was referring to this for some unrelated work... I must have written these tests close to 5 years ago and apparently never noticed the missing A...

loic-sharma
loic-sharma approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch - LGTM!

@cbracken cbracken changed the title [embedder] Fix typo in embedderA11yTests [embedder] Fix typo in EmbedderA11yTest May 4, 2022
@cbracken cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 4, 2022
@cbracken
[embedder] Fix typo in embedderA11yTests
92d3e29 
We were missing the 'A' in Accessibility.
@fluttergithubbot fluttergithubbot merged commit b5e7336 into flutter:main May 5, 2022
@cbracken cbracken deleted the fix-a11y-typo branch May 5, 2022 03:17
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2022
@engine-flutter-autoroll
b5e7336 [embedder] Fix typo in EmbedderA11yTest (flutter/engine#33120)
8681e10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@loic-sharma loic-sharma loic-sharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

embedder Related to the embedder API waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbracken @loic-sharma @fluttergithubbot