Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use Robolectric's Config#qualifiers to set locale for tests #32984

Merged
fluttergithubbot merged 1 commit into from
Apr 29, 2022
Merged

Use Robolectric's Config#qualifiers to set locale for tests #32984

fluttergithubbot merged 1 commit into from
Apr 29, 2022

Conversation

@utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Apr 28, 2022

Use Robolectric's Config#qualifiers to configure locale for tests instead of current TestUtils#setLegacyLocale. This PR also removs TestUtils because its method all replaced by Robolectric's APIs. Please see http://robolectric.org/using-qualifiers/ for details.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@utzcoz
Use Robolectric's Config#qualifiers to set locale for tests
b87a89b 
Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz changed the title Use Robolectric's Config#qualifers to set locale for tests Use Robolectric's Config#qualifiers to set locale for tests Apr 28, 2022
@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 29, 2022

Hi @zanderso , could you help to review this PR? Thanks.

@jason-simmons jason-simmons requested a review from blasten April 29, 2022 14:49
@jason-simmons jason-simmons added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 29, 2022
@fluttergithubbot fluttergithubbot merged commit 2f7c922 into flutter:main Apr 29, 2022
@utzcoz utzcoz deleted the use-Robolectric-Config-to-configure-locale branch April 29, 2022 16:43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2022
@engine-flutter-autoroll
2f7c922 Use Robolectric's Config#qualifiers to set locale for tests (f…
400c61e 
…lutter/engine#32984)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@blasten blasten blasten approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@utzcoz @blasten @jason-simmons @fluttergithubbot