-
Notifications
You must be signed in to change notification settings - Fork 6k
[fuchsia] Remove spurious ERROR log #32870
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Gold has detected about 51 new digest(s) on patchset 4. |
|
You'll need to rebase on upstream/master to get rid of the rest of the unrelated commits from your change. I typically do and then |
akbiggs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuchsia changes LGTM, will approve and merge once rebased on upstream/master.
9fed23d to
fc3408e
Compare
fxbug.dev/98398
|
Tested flutter_runner_tests, came clean (had to disable one GFX test that actually uses TouchSource, which this PR explicitly turns off). Also tested against ToT Fuchsia touch-input-test, the ERROR log is now gone. And also rebased against ToT flutter as well. PTAL! |
This PR avoids setting up the fuchsia.ui.pointer.TouchSource/MouseSource watch loop when in GFX mode. We employ a boolean parameter to tell the difference to the superclass PlatformView constructor, and the scoping is limited to that ctor.
Noisy PlatformView constructor
Pre-launch Checklist
writing and running engine tests.
///).