Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@jaeheon
Copy link
Contributor

@jaeheon jaeheon commented Apr 22, 2022

This PR avoids setting up the fuchsia.ui.pointer.TouchSource/MouseSource watch loop when in GFX mode. We employ a boolean parameter to tell the difference to the superclass PlatformView constructor, and the scoping is limited to that ctor.

Noisy PlatformView constructor

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • [ x I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@skia-gold
Copy link

Gold has detected about 51 new digest(s) on patchset 4.
View them at https://flutter-engine-gold.skia.org/cl/github/32870

@jaeheon jaeheon requested a review from akbiggs April 22, 2022 19:37
@arbreng arbreng changed the title Watch loop off [fuchsia] Remove spurious ERROR log Apr 22, 2022
@akbiggs
Copy link
Contributor

akbiggs commented Apr 22, 2022

You'll need to rebase on upstream/master to get rid of the rest of the unrelated commits from your change. I typically do

git checkout upstream/master
git cherry-pick -c 2461ef3cfb72646f35ec607ba84e21d4540d2226
git push origin HEAD:refs/heads/watch-loop-off --force

and then git push origin HEAD:refs/heads/watch-loop-off --force for any follow-up changes.

Copy link
Contributor

@akbiggs akbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuchsia changes LGTM, will approve and merge once rebased on upstream/master.

@jaeheon jaeheon force-pushed the watch-loop-off branch 2 times, most recently from 9fed23d to fc3408e Compare April 22, 2022 23:08
@jaeheon
Copy link
Contributor Author

jaeheon commented Apr 22, 2022

Tested flutter_runner_tests, came clean (had to disable one GFX test that actually uses TouchSource, which this PR explicitly turns off).

Also tested against ToT Fuchsia touch-input-test, the ERROR log is now gone.

And also rebased against ToT flutter as well.

PTAL!

@akbiggs akbiggs added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 22, 2022
@fluttergithubbot fluttergithubbot merged commit 0e8e617 into flutter:main Apr 23, 2022
@jaeheon jaeheon deleted the watch-loop-off branch April 23, 2022 01:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-android platform-fuchsia waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants