This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Migrate Flutter Web to JS static interop - 14. #32683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@srujzs ptal, just one class with a factory constructor. |
Contributor
|
LGTM |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
test-exempt: code refactor with no semantic change |
eyebrowsoffire
approved these changes
Apr 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 25, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2022
zanderso
added a commit
that referenced
this pull request
Apr 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2022
zanderso
added a commit
to flutter/flutter
that referenced
this pull request
Apr 26, 2022
* b2ca1ce [web] Migrate Flutter Web to JS static interop - 14. (flutter/engine#32683) * d3886d6 Roll Fuchsia Linux SDK from MbA1RtjV4... to YyokSAVV4... (flutter/engine#32907) * 0aca7c0 Roll Skia from 4f33f5bef8eb to f8e52b27aa70 (4 revisions) (flutter/engine#32911) * ccf0754 Roll Skia from f8e52b27aa70 to 74742130b08d (2 revisions) (flutter/engine#32913) * a2d8df9 Roll Skia from 74742130b08d to 82146a7fcde2 (1 revision) (flutter/engine#32914) * 1e19613 Roll Fuchsia Mac SDK from JVNKiIJWP... to Jki3kG8_P... (flutter/engine#32916) * 65bc7e3 Roll Dart SDK from 865c2ff0940e to e89b629ed91d (1 revision) (flutter/engine#32917) * 7915213 Revert "[web] Migrate Flutter Web to JS static interop - 14. (#32683)" (flutter/engine#32919) * Add impellerc to conductor codesigning list * Update coductor codesigning for libtessellator.dylib Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 4, 2022
* b2ca1ce [web] Migrate Flutter Web to JS static interop - 14. (flutter/engine#32683) * d3886d6 Roll Fuchsia Linux SDK from MbA1RtjV4... to YyokSAVV4... (flutter/engine#32907) * 0aca7c0 Roll Skia from 4f33f5bef8eb to f8e52b27aa70 (4 revisions) (flutter/engine#32911) * ccf0754 Roll Skia from f8e52b27aa70 to 74742130b08d (2 revisions) (flutter/engine#32913) * a2d8df9 Roll Skia from 74742130b08d to 82146a7fcde2 (1 revision) (flutter/engine#32914) * 1e19613 Roll Fuchsia Mac SDK from JVNKiIJWP... to Jki3kG8_P... (flutter/engine#32916) * 65bc7e3 Roll Dart SDK from 865c2ff0940e to e89b629ed91d (1 revision) (flutter/engine#32917) * 7915213 Revert "[web] Migrate Flutter Web to JS static interop - 14. (flutter#32683)" (flutter/engine#32919) * Add impellerc to conductor codesigning list * Update coductor codesigning for libtessellator.dylib Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
CaseyHillers
pushed a commit
to flutter/flutter
that referenced
this pull request
May 4, 2022
* b2ca1ce [web] Migrate Flutter Web to JS static interop - 14. (flutter/engine#32683) * d3886d6 Roll Fuchsia Linux SDK from MbA1RtjV4... to YyokSAVV4... (flutter/engine#32907) * 0aca7c0 Roll Skia from 4f33f5bef8eb to f8e52b27aa70 (4 revisions) (flutter/engine#32911) * ccf0754 Roll Skia from f8e52b27aa70 to 74742130b08d (2 revisions) (flutter/engine#32913) * a2d8df9 Roll Skia from 74742130b08d to 82146a7fcde2 (1 revision) (flutter/engine#32914) * 1e19613 Roll Fuchsia Mac SDK from JVNKiIJWP... to Jki3kG8_P... (flutter/engine#32916) * 65bc7e3 Roll Dart SDK from 865c2ff0940e to e89b629ed91d (1 revision) (flutter/engine#32917) * 7915213 Revert "[web] Migrate Flutter Web to JS static interop - 14. (#32683)" (flutter/engine#32919) * Add impellerc to conductor codesigning list * Update coductor codesigning for libtessellator.dylib Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com> Co-authored-by: engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
egramond
pushed a commit
to egramond/flutter
that referenced
this pull request
May 5, 2022
* b2ca1ce [web] Migrate Flutter Web to JS static interop - 14. (flutter/engine#32683) * d3886d6 Roll Fuchsia Linux SDK from MbA1RtjV4... to YyokSAVV4... (flutter/engine#32907) * 0aca7c0 Roll Skia from 4f33f5bef8eb to f8e52b27aa70 (4 revisions) (flutter/engine#32911) * ccf0754 Roll Skia from f8e52b27aa70 to 74742130b08d (2 revisions) (flutter/engine#32913) * a2d8df9 Roll Skia from 74742130b08d to 82146a7fcde2 (1 revision) (flutter/engine#32914) * 1e19613 Roll Fuchsia Mac SDK from JVNKiIJWP... to Jki3kG8_P... (flutter/engine#32916) * 65bc7e3 Roll Dart SDK from 865c2ff0940e to e89b629ed91d (1 revision) (flutter/engine#32917) * 7915213 Revert "[web] Migrate Flutter Web to JS static interop - 14. (flutter#32683)" (flutter/engine#32919) * Add impellerc to conductor codesigning list * Update coductor codesigning for libtessellator.dylib Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is CL 14 in a series of CLs to migrate Flutter Web to the new JS static interop API.
This CL migrates a single class in js_url_strategy.dart.