[ui] cleanup natives.dart #31776
[ui] cleanup natives.dart #31776
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| Function? _getCallbackFromHandle(int handle) native 'GetCallbackFromHandle'; | ||
|
|
||
| // Required for gen_snapshot to work correctly. | ||
| int? _isolateId; // ignore: unused_element |
There was a problem hiding this comment.
I can find no references to this in the engine or in the dart/sdk. Since it does not have a pragma it is almost certainly getting tree shaken
There was a problem hiding this comment.
Confirmed this was removed from the Dart SDK in https://dart-review.googlesource.com/c/sdk/+/129742 and is safe to delete
This comment was marked as outdated.
This comment was marked as outdated.
|
test-exempt: code refactor with no semantic change |
f647bc3 to
304e76e
Compare
I added types and breadcrumbs to some methods here. Also deleted some historic code that is no longer required (deleted in https://dart-review.googlesource.com/c/sdk/+/129742 )