Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add an embedder.h API for scheduling frame #31304

Merged
fluttergithubbot merged 4 commits into from
Feb 17, 2022
Merged

Add an embedder.h API for scheduling frame #31304

fluttergithubbot merged 4 commits into from
Feb 17, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Feb 7, 2022 •
edited
Loading

Add an embedder.h API for scheduling frame
fix flutter/flutter#69716

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Feb 7, 2022
@ColdPaleLight ColdPaleLight changed the title Add an embedder.h API for scheduling frame [WIP]Add an embedder.h API for scheduling frame Feb 7, 2022
@ColdPaleLight ColdPaleLight added the Work in progress (WIP) Not ready (yet) for review! label Feb 7, 2022
@ColdPaleLight ColdPaleLight force-pushed the embedder_schedule_frame branch from f96bd99 to 5eb1c48 Compare February 7, 2022 17:05
@ColdPaleLight ColdPaleLight changed the title [WIP]Add an embedder.h API for scheduling frame Add an embedder.h API for scheduling frame Feb 7, 2022
@ColdPaleLight ColdPaleLight removed Work in progress (WIP) Not ready (yet) for review! platform-fuchsia labels Feb 7, 2022
@stuartmorgan-g stuartmorgan-g requested review from chinmaygarde and removed request for stuartmorgan-g February 7, 2022 19:03
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 17, 2022
@fluttergithubbot fluttergithubbot merged commit a46eae9 into flutter:main Feb 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 18, 2022
@engine-flutter-autoroll
a46eae9 Add an embedder.h API for scheduling frame (flutter/engine#31304
a382b6e 
)
@loic-sharma loic-sharma mentioned this pull request Jul 6, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken cbracken is a code owner

@dnfield dnfield Awaiting requested review from dnfield

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

embedder Related to the embedder API platform-fuchsia platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an embedder.h API for requesting a redraw

4 participants

@ColdPaleLight @chinmaygarde @jason-simmons @fluttergithubbot