This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[win32] support high frame rates #28927
Merged
fluttergithubbot
merged 7 commits into
flutter:main
from
jonahwilliams:windows-frame-rate
Mar 3, 2022
Merged
[win32] support high frame rates #28927
fluttergithubbot
merged 7 commits into
flutter:main
from
jonahwilliams:windows-frame-rate
Mar 3, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e564e54 to
9bfb84f
Compare
9bfb84f to
c753939
Compare
b1a8771 to
2962099
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
dnfield
approved these changes
Mar 3, 2022
Contributor
dnfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit
fml/platform/win/message_loop_win.cc
Outdated
Comment on lines
12
to
13
| const uint32_t kHighResolutionTimer = 1; // 1 ms | ||
| const uint32_t kLowResolutionTimer = 15; // 15 ms |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constexpr
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 3, 2022
|
AWESOME! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
platform-windows
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the win32 embedding, asking dwm for the frame rate and use this to schedule frames instead of only using 60 hz. For UWP this remains 60 hz.
Increase the default timer resolution for win 10 and greater. I think this restriction could be loosened a bit in the future, but this is a fairly conservative choice.