This repository was archived by the owner on Feb 25, 2025. It is now read-only.
No more gradlew #28264
Merged
No more gradlew #28264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The license checker has flagged an issue |
Contributor
Author
|
Looking into that - it's failing to realize this is apache licensed somehow. |
Contributor
Author
|
Ok, telling the tool to ignore |
Contributor
Author
|
Builds should succeed now. |
blasten
reviewed
Aug 23, 2021
|
|
||
| SCRIPT_PATH = os.path.dirname(os.path.realpath(__file__)) | ||
|
|
||
| BAT = '.bat' if sys.platform.startswith(('cygwin', 'win')) else '' |
Member
|
Presubmit still looks sad about the license tool signature. Otherwise lgtm |
zanderso
approved these changes
Aug 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes gradle wrapper from Android projects, updates build rules/scripts. This eliminates downloading gradle itself at build time, but does not eliminate other network connections gradle makes to download app dependencies.
I created the cipd package by downloading the gradle distribution, unzipping it, and running:
Part of flutter/flutter#88717