This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] use a different method for launching desktop safari #27567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ferhatb
approved these changes
Jul 19, 2021
923a1c7 to
65489d0
Compare
Contributor
Author
|
Merging on red LUCI to fix the build. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 20, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
open -F -W -n -b com.apple.Safariwith a direct invocation of the/Applications/Safari.app/Contents/MacOS/Safariexecutable.Problems with
open:openprocess itself is short-lived and exits immediately after launching Safari. This is contrary to the assumptions made by the rest of the code that the lifetime of the process returned by theBrowserclass corresponds to the browser process.opencommand and/orcom.apple.Safarialso open the "default browser". For example, if your default browser is set to Chrome, then the test will also open in Chrome.The method used here is borrowed from Karma: karma-runner/karma-safari-launcher#29
This also removes the "clear console" functionality when felt is run in normal mode (as opposed to watch mode), which could be messing with LUCI logs.
This also removes the printouts of macOS info, because commands we use to extract this info are flaky.
Fixes flutter/flutter#86676