Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Migrate to ci.yaml #26271

Merged
fluttergithubbot merged 2 commits into from
May 21, 2021
Merged

Migrate to ci.yaml #26271

fluttergithubbot merged 2 commits into from
May 21, 2021

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented May 19, 2021

Issues

flutter/flutter#82303

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

@google-cla google-cla bot added the cla: yes label May 19, 2021
@CaseyHillers CaseyHillers mentioned this pull request May 19, 2021
Closed
9 tasks
christopherfujino
christopherfujino approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 21, 2021
@fluttergithubbot fluttergithubbot merged commit 9869fdf into flutter:master May 21, 2021
@CaseyHillers CaseyHillers deleted the star-migration branch May 21, 2021 18:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 21, 2021
@engine-flutter-autoroll
9869fdf Migrate to ci.yaml (flutter/engine#26271)
6efbc44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaseyHillers @christopherfujino @fluttergithubbot