This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macos] Make metal the default rendering backend on macOS >= 10.14 #23967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62b06ea to
9dc35f7
Compare
8da4789 to
ba7fda7
Compare
chinmaygarde
approved these changes
Feb 22, 2021
ba7fda7 to
ca5bf56
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2021
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Unless I'm missing some code here, this needs to be reverted; see comment below.
| @implementation FlutterRenderingBackend | ||
|
|
||
| + (BOOL)renderUsingMetal { | ||
| if (@available(macOS 10.14, *)) { |
Contributor
There was a problem hiding this comment.
Per previous discussion, there are two aspects to enabling Metal:
- What OS version we (read: Skia) are comfortable enabling Metal on.
- Whether the current host hardware supports Metal (not all Macs that can run macOS 10.14 support Metal)
I'm not seeing any querying of the second here, which would make this logic incorrect. See also flutter/flutter#76710
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: flutter/flutter#74058