Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[null-safety] increase sky engine min sdk#22322

Merged
jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams:sky_engine_patch
Nov 6, 2020
Merged

[null-safety] increase sky engine min sdk#22322
jonahwilliams merged 3 commits intoflutter:masterfrom
jonahwilliams:sky_engine_patch

Conversation

@jonahwilliams
Copy link
Contributor

Description

To silence pub warning:

Running "flutter pub get" in project_root...                       181ms
The package resolution is not fully migrated to null-safety.            
                                                                        
package:sky_engine is not opted into null safety in its pubspec.yaml:   
  ╷                                                                     
8 │   sdk: '>=1.11.0 <3.0.0'                                            
  │        ^^^^^^^^^^^^^^^^^                                            
  ╵                                                                     
                                                                        
Either downgrade your sdk constraint, or invoke dart/flutter with       
`--no-sound-null-safety`.                                               
                                                                        
To learn more about available versions of your dependencies try running 
`pub outdated --mode=null-safety`.                                      
                                                                        
See more at https://dart.dev/null-safety/migration-guide.    

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@jonahwilliams jonahwilliams changed the title [null-safety] increase sky engine version [null-safety] increase sky engine min sdk Nov 5, 2020
@zanderso
Copy link
Member

zanderso commented Nov 5, 2020

Uh oh:

Using analyzer from /b/s/w/ir/cache/builder/src/third_party/dart/tools/sdks/dart-sdk/bin/dartanalyzer
dartanalyzer version 2.11.0-190.0.dev

@jonahwilliams
Copy link
Contributor Author

I guess we're using the checked-in Dart SDK to analyze things?

@zanderso
Copy link
Member

zanderso commented Nov 5, 2020

Hmm. On further thought, that might be the right thing to do here. But then this PR would have to wait on the roll of Dart's prebuilt dev SDK to 2.12. @mit-mit

@jonahwilliams
Copy link
Contributor Author

Looks like its working now, will land on green

@jonahwilliams jonahwilliams merged commit 4b5b496 into flutter:master Nov 6, 2020
@jonahwilliams jonahwilliams deleted the sky_engine_patch branch November 6, 2020 02:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 6, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants