Add Linux Wayland support#20629
Conversation
828debe to
7dadbb1
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@robert-ancell CLA consent required ^^^ |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
shell/platform/linux/BUILD.gn
Outdated
| configs += [ "//flutter/shell/platform/linux/config:gtk" ] | ||
| configs += [ | ||
| "//flutter/shell/platform/linux/config:gtk", | ||
| "//flutter/shell/platform/linux/config:wayland-egl" |
There was a problem hiding this comment.
This should have a trailing comma and is stopping the build.
You can format this locally with gn format shell/platform/linux/BUILD.gn.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
as of flutter/engine#20629 this work around is no longer needed.
|
Is there still something missing regarding input methods on Wayland? The GNOME on screen keyboard, which works fine in native GNOME apps, does not show up with Flutter apps on Wayland. The keyboard does show up with Flutter apps when running X, though. |
|
I'm not aware of this bug or what might cause it. I'll look into it. |
Description
WIP based on top of #20336
Adds Wayland support to the Linux/GTK platform. Most of what's required come from GTK's Wayland support, but we need to do some things in the renderer to make it work with Flutter. Specifically we need to control an EGL surface, and to do that we make a Wayland subsurface off of the main surface GTK creates.
Related Issues
flutter/flutter#57932
Tests
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.