This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Minor documentation details/breadcrumbs#20330
Merged
cbracken merged 1 commit intoflutter:masterfrom Oct 3, 2020
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
reviewed
Aug 10, 2020
shell/platform/android/io/flutter/view/AccessibilityBridge.java
Outdated
Show resolved
Hide resolved
cbracken
reviewed
Sep 14, 2020
Member
cbracken
left a comment
There was a problem hiding this comment.
LGTM once shell/platform/android/io/flutter/view/AccessibilityBridge.java is reverted.
shell/platform/android/io/flutter/view/AccessibilityBridge.java
Outdated
Show resolved
Hide resolved
cbracken
reviewed
Sep 14, 2020
Adds a reference to RenderObject.describeSemanticsClip to `SemanticsFlag.isHidden` and a hint that lets readers know that the `SemanticsNode` rect is specified in local coordinates.
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2020
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Oct 20, 2020
Adds a reference to RenderObject.describeSemanticsClip to `SemanticsFlag.isHidden` and a hint that lets readers know that the `SemanticsNode` rect is specified in local coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor documentation details/breadcrumbs from debugging flutter/flutter#61631 and flutter/flutter#36307
Related framework PR: flutter/flutter#63192
Related Issues
N/A
Tests
N/A
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.