This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[windows] Rework controller/engine interaction in the API#20266
Merged
stuartmorgan-g merged 3 commits intoflutter:masterfrom Aug 10, 2020
Merged
[windows] Rework controller/engine interaction in the API#20266stuartmorgan-g merged 3 commits intoflutter:masterfrom
stuartmorgan-g merged 3 commits intoflutter:masterfrom
Conversation
clarkezone
approved these changes
Aug 7, 2020
clarkezone
left a comment
There was a problem hiding this comment.
Couple of questions / comments, otherwise LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes the interaction between the view controller and engine in both the C API and
the engine API, so that there's always an engine (as on other platforms) rather than
the engine APIs being specific to headless mode.
While adjusting the C API, this does a large cleanup:
FlutterDesktop(prefix) + "class" name + method-style name.E.g.,
FlutterDestkopViewControllerCreaterather thanFlutterDesktopCreateViewController.This makes it easier to see what functions operate on which conceptual "object" in the API.
Related Issues
Fixes flutter/flutter#61966
Tests
I added the following tests: Adjusted client wrapper tests for the changes.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.
This is only a breaking change at the C API level, so is very unlikely to affect actual users since the template only uses the C++ wrapper.