add onDisplayOverlaySurface JNI #18859
Conversation
| private final Map<Integer, FlutterNativeView> overlaySurfaceViews = new HashMap<>(); | ||
|
|
||
| public void displayOverlaySurface(int id, int x, int y, int width, int height) { | ||
| Log.e( |
There was a problem hiding this comment.
let's remove the changes from this file
| if (flutterView == null) { | ||
| throw new RuntimeException("Cannot create an overlay surface without a flutter view"); | ||
| } | ||
| ((FlutterView) flutterView).displayOverlaySurface(id, x, y, width, height); |
There was a problem hiding this comment.
Add a TODO comment similar to the previous one
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Description
Add JNI method
onDisplayOverlaySurfacefor hybrid composition in the engine.Related Issues
flutter/flutter#58288
Tests
I added the following tests:
onDisplayOverlaySurface__callsPlatformViewsControllerChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.