This repository was archived by the owner on Feb 25, 2025. It is now read-only.
compensate for DPR in canvas blur #18484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
approved these changes
May 18, 2020
Contributor
Author
|
luci-engine failures are Fuchsia flakes. Ignoring. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2020
wandyers
pushed a commit
to wandyers/engine
that referenced
this pull request
May 23, 2020
* compensate for DPR in canvas blur
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying blur on the 2D canvas the canvas applies it in bitmap pixels. However, because
bitmapSize / cssSize = devicePixelRatio(source), the blur ends up being inconsistent with the CSS blur applied to DOM elements.This change applies device-pixel ratio to the canvas blur so the two are consistent.
Fixes flutter/flutter#55933.
Requires flutter/goldens#97