This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Remove Samsung workaround" #18081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a5e0b2f.
jason-simmons
approved these changes
May 1, 2020
Member
|
@GaryQian does the upcoming 1.17 release have this bug? |
Contributor
Author
|
It likely does, but I don't have a repro, so will see if customer sees it fixed. |
Contributor
Author
|
If it does repro, it would only be on a small amount of Samsung devices, as I have verified it does not occur on most of the common ones. |
Contributor
Author
|
Analyzer failure fixed by flutter/flutter#56139. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #17612
We are seeing resurgence of the duplication bug: flutter/flutter#55730
We should re-apply this for now and try to remove it at a later date.