Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Use correct shell operator to compare file limits #18032

Merged
mdebbar merged 1 commit into from
Apr 30, 2020
Merged

[web] Use correct shell operator to compare file limits #18032

mdebbar merged 1 commit into from
Apr 30, 2020

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Apr 29, 2020

if [[ $MAX_ULIMIT_FILES < 50000 ]] performs a string comparison. But we want an integer comparison which can be done like this: if [[ $MAX_ULIMIT_FILES -lt 50000 ]].

Source: https://tldp.org/LDP/abs/html/comparison-ops.html

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Apr 29, 2020
@mdebbar mdebbar requested a review from nturgut April 29, 2020 18:00
@mdebbar mdebbar self-assigned this Apr 29, 2020
@mdebbar mdebbar merged commit 7c084c5 into flutter:master Apr 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
459223e 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
ffafd98 
…ter/engine#18032)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
92e5d9b 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
828631b 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
628a1a4 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
9d7b5ca 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
0bc72cb 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
77b93ea 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
8afbc90 
…ter/engine#18032)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
7cb3e92 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
1cff02b 
…ter/engine#18032)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
2c34115 
…ter/engine#18032)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
302de25 
…ter/engine#18032)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
490b52e 
…ter/engine#18032)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
e99f43d 
…ter/engine#18032)
This was referenced May 1, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
b3fa494 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
1409a21 
…ter/engine#18032)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
75782a5 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
0499517 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
f12f026 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
a432940 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
49a23df 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
7158c51 
…ter/engine#18032)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2020
@engine-flutter-autoroll
7c084c5 [web] Use correct shell operator to compare file limits (flut…
b6a2a56 
…ter/engine#18032)
@mdebbar mdebbar deleted the felt_ulimit_lt branch April 15, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@nturgut nturgut nturgut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdebbar mdebbar

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdebbar @nturgut @googlebot