Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commits) #18025

Merged
fluttergithubbot merged 1 commit into from
Apr 29, 2020
Merged

Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commits) #18025

fluttergithubbot merged 1 commit into from
Apr 29, 2020

Conversation

@skia-flutter-autoroll
Copy link
Contributor

@skia-flutter-autoroll skia-flutter-autoroll commented Apr 29, 2020

https://dart.googlesource.com/sdk.git/+log/207953f367e6..05b7f49c7267

git log 207953f..05b7f49 --date=short --first-parent --format='%ad %ae %s'
2020-04-29 cskau@google.com [VM] Fixes missing bits for new sync* transform.
2020-04-29 scheglov@google.com Fix leak of changed FileState(s).
2020-04-29 rmacnak@google.com [vm] Speed up reload in debug mode by avoiding costly checks in ~HandleScope.

Created with:
gclient setdep -r src/third_party/dart@05b7f49c7267

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com

@skia-flutter-autoroll
Roll src/third_party/dart 207953f..05b7f49 (3 commits)
5a42473 
https://dart.googlesource.com/sdk.git/+log/207953f367e6..05b7f49c7267

git log 207953f..05b7f49 --date=short --first-parent --format='%ad %ae %s'
2020-04-29 cskau@google.com [VM] Fixes missing bits for new sync* transform.
2020-04-29 scheglov@google.com Fix leak of changed FileState(s).
2020-04-29 rmacnak@google.com [vm] Speed up reload in debug mode by avoiding costly checks in ~HandleScope.

Created with:
  gclient setdep -r src/third_party/dart@05b7f49c7267

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: dart-vm-team@google.com
@skia-flutter-autoroll skia-flutter-autoroll added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 29, 2020
@fluttergithubbot fluttergithubbot merged commit 2e33ef8 into flutter:master Apr 29, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
2b32f23 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
1305d4c 
…ts) (flutter/engine#18025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
b19b991 
…ts) (flutter/engine#18025)
This was referenced Apr 29, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
de12a2b 
…ts) (flutter/engine#18025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 29, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
6718610 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
bcf0982 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
1f284c9 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
b23348b 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
b0af888 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
df52683 
…ts) (flutter/engine#18025)
This was referenced Apr 30, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
85fb603 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
e17360a 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
1ddcd8d 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
bbe7c5e 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
658ed18 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
9326af4 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
5a0bd62 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
29fb527 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
7c91f1c 
…ts) (flutter/engine#18025)
This was referenced May 1, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
5f326a4 
…ts) (flutter/engine#18025)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
c11635c 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
b3cbd1d 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
65b8540 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
c9ac3ed 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
2708511 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 1, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
12b9270 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 1, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 2, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
37404de 
…ts) (flutter/engine#18025)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 2, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2020
@engine-flutter-autoroll
2e33ef8 Roll src/third_party/dart 207953f367e6..05b7f49c7267 (3 commi…
f2af0fc 
…ts) (flutter/engine#18025)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skia-flutter-autoroll @googlebot @fluttergithubbot