This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Use dart::ComponentContext() #17876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
612c771 to
254d2db
Compare
cbracken
reviewed
Apr 24, 2020
chinmaygarde
approved these changes
Apr 24, 2020
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM after a comment cross referencing the fxr tracking the SDK update.
Contributor
Author
Filed https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=50815 per your request. |
cbracken
approved these changes
Apr 25, 2020
254d2db to
3a25bd5
Compare
This functionality is added in issue flutter#41523. Allows runners to request the singleton instance of `sys::ComponentContext`, while it remains also accessible to component-specific code that does not have direct access to top-level objects. Fixes flutter#41523
3a25bd5 to
af7dc3f
Compare
Contributor
Author
|
@chinmaygarde Anything else needed to merge this? Thanks! |
Contributor
|
Nope. Let's merge this. Do you have merge commit privileges or should I commit? go/flutter-onboarding has a section on how to get them. |
Contributor
Author
|
I don't have commit rights at the moment. Would you mind merging? I'll start with flutter onboarding in case I need it in the future. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2020
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 30, 2020
This will allow introspection of the state of tzdata loader, making error diagnostics easier on Fuchsia. Must be merged only after this pull request is merged into flutter flutter/engine#17876 Otherwise, the call to the `dart::ComponentContext()` could prevent the runners from initializing the component context correctly. Tested: Compiled and deployed on a Fuchsia device. The result on Fuchsia is as seen below. ``` $ fx iquery /hub/c/flutter_jit_product_runner.cmx/21608/out/diagnostics: /hub/c/flutter_jit_product_runner.cmx/21608/out/diagnostics#os: dst_status = 0 tz_data_close_status = 0 tz_data_status = 0 ``` See issue #41525 for details. Bug: fuchsia:43341 Change-Id: I43ea289003e1e1d09cca4163236bc477eb9cee80 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144480 Reviewed-by: Martin Kustermann <kustermann@google.com> Commit-Queue: Filip Filmar <fmil@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is added in dart-lang/sdk#41523. Allows runners to request
the singleton instance of
sys::ComponentContext, while it remains alsoaccessible to component-specific code that does not have direct access
to top-level objects.
Fixes dart-lang/sdk#41523