This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Read SkSL from json asset #17861
Merged
Read SkSL from json asset #17861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jonahwilliams : let's forget about iOS Metal for now until developers ask for it. This should unblock us on iOS32 and Android. The Metal iOS would still load those SkSLs but they probably won't eliminate the compilation jank for now. |
chinmaygarde
approved these changes
Apr 22, 2020
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
Some minor nits. Otherwise lgtm.
shell/common/persistent_cache.cc
Outdated
|
|
||
| #include "flutter/shell/common/persistent_cache.h" | ||
|
|
||
| #include <rapidjson/document.h> |
Contributor
There was a problem hiding this comment.
Nit: Square brackets for system headers and quotes for others. This goes at the bottom with the others.
| SkBase64 decoder; | ||
| auto error = decoder.decode(input.c_str(), input.length()); | ||
| if (error != SkBase64::Error::kNoError) { | ||
| FML_LOG(ERROR) << "Base64 can't decode: " << input; |
Contributor
There was a problem hiding this comment.
Nit: Also dump the error maybe?
shell/common/persistent_cache.h
Outdated
| static void MarkStrategySet() { strategy_set_ = true; } | ||
|
|
||
| static constexpr char kSkSLSubdirName[] = "sksl"; | ||
| static constexpr char kAssetFileName[] = "shaders.json"; |
Contributor
There was a problem hiding this comment.
This seems like an all too common name and may collide with other assets. How about io.flutter.shaders.json or something more indicative of its purpose?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#55219