-
Notifications
You must be signed in to change notification settings - Fork 6k
Trial PR to enable null safety unfork in the Dart SDK. #17818
Conversation
|
@a-siva - it looks like @leafpetersen 's fix landed: https://dart-review.googlesource.com/c/sdk/+/144220 Can you roll this forward and re-run? |
|
Tests are passing for me on chrome, but i seem to able to repro the firefox breakage. Just sanity checking that they run on a clean branch. |
dart-lang/sdk@ cab69e7 [BUILD] - Initial CL to unfork the NNBD Dart SDK NOTE: This is a trial submit and will be reverted immediately.
|
@yjbanov @sigmundch - fyi, other issues appear to be fixed, but we're now seeing a new felt error here: Is this possibly a flake? |
|
It appears to be a flake, the same issue is also seen in the engine buildbot from time to time |
|
I take that back, the time out we are seeing here is different from the one the engine buildbot is flaking on (scenario_app unit test). This PR appears to be timing out loading some fonts. |
|
It has been re-run once already |
|
THe re-run is happening at https://ci.chromium.org/p/flutter/builders/try/Mac%20Web%20Engine/2632 |
|
Looks like your new run is green? Is it possible to kick off a framework test run with this version of the engine? |
|
Submitting the PR to do a trial PR of the framework. |
This is a Trial PR to try and test the effect of the Dart unfork CL on the flutter engine build.