Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@a-siva
Copy link
Contributor

@a-siva a-siva commented Apr 20, 2020

This is a Trial PR to try and test the effect of the Dart unfork CL on the flutter engine build.

@auto-assign auto-assign bot requested a review from GaryQian April 20, 2020 04:23
@vsmenon
Copy link
Contributor

vsmenon commented Apr 21, 2020

@a-siva - it looks like @leafpetersen 's fix landed:

https://dart-review.googlesource.com/c/sdk/+/144220

Can you roll this forward and re-run?

@vsmenon
Copy link
Contributor

vsmenon commented Apr 21, 2020

Tests are passing for me on chrome, but i seem to able to repro the firefox breakage. Just sanity checking that they run on a clean branch.

a-siva added 3 commits April 27, 2020 00:49
dart-lang/sdk@ cab69e7 [BUILD] - Initial CL to unfork the NNBD Dart SDK NOTE: This is a trial submit and will be reverted immediately.
@vsmenon
Copy link
Contributor

vsmenon commented Apr 27, 2020

@yjbanov @sigmundch - fyi, other issues appear to be fixed, but we're now seeing a new felt error here:

00:36 �[32m+336�[0m�[33m ~24�[0m�[31m -1�[0m: test/text/font_loading_test.dart: loadFontFromList loading font should send font change message �[1m�[31m[E]�[0m�[0m                                                                                 
  TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.

Is this possibly a flake?

@a-siva
Copy link
Contributor Author

a-siva commented Apr 27, 2020

It appears to be a flake, the same issue is also seen in the engine buildbot from time to time

@a-siva
Copy link
Contributor Author

a-siva commented Apr 27, 2020

I take that back, the time out we are seeing here is different from the one the engine buildbot is flaking on (scenario_app unit test). This PR appears to be timing out loading some fonts.

@vsmenon
Copy link
Contributor

vsmenon commented Apr 27, 2020

@yjbanov @ferhatb - have you seen this error before (Mac Web Engine)? (test/text/font_loading_test.dart: loadFontFromList loading font should send font change message)

The same test appears to pass on Linux. Is there a way to rerun the Mac one?

@a-siva
Copy link
Contributor Author

a-siva commented Apr 27, 2020

It has been re-run once already

@a-siva
Copy link
Contributor Author

a-siva commented Apr 27, 2020

@vsmenon
Copy link
Contributor

vsmenon commented Apr 27, 2020

Looks like your new run is green?

Is it possible to kick off a framework test run with this version of the engine?

@a-siva
Copy link
Contributor Author

a-siva commented Apr 28, 2020

Submitting the PR to do a trial PR of the framework.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants