Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update the Metal backend selection to use iOS 10.0 and A7 as the version floor. #17162

Merged
dnfield merged 1 commit into from
Mar 15, 2020
Merged

Update the Metal backend selection to use iOS 10.0 and A7 as the version floor. #17162

dnfield merged 1 commit into from
Mar 15, 2020

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Mar 15, 2020

@auto-assign auto-assign bot requested a review from GaryQian March 15, 2020 20:30
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 15, 2020
dnfield
dnfield reviewed Mar 15, 2020
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 15, 2020

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Mar 15, 2020
@dnfield dnfield merged commit d8e45f9 into flutter:master Mar 15, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2020
@engine-flutter-autoroll
d8e45f9 Update the Metal backend selection to use iOS 10.0 and A7 as …
ac22d0b 
…the version floor. (flutter/engine#17162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2020
@engine-flutter-autoroll
d8e45f9 Update the Metal backend selection to use iOS 10.0 and A7 as …
e5b5334 
…the version floor. (flutter/engine#17162)
This was referenced Mar 16, 2020
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 16, 2020
@engine-flutter-autoroll
d8e45f9 Update the Metal backend selection to use iOS 10.0 and A7 as …
6c4e777 
…the version floor. (flutter/engine#17162)
@chinmaygarde chinmaygarde deleted the feature_set branch April 13, 2020 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

@GaryQian GaryQian Awaiting requested review from GaryQian

1 more reviewer

@dnfield dnfield dnfield left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Finalize iOS and device family versions for Metal renderer selection.

4 participants

@chinmaygarde @fluttergithubbot @dnfield @googlebot