Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" #17040

Merged
yjbanov merged 1 commit into from
Mar 10, 2020
Merged

Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" #17040

yjbanov merged 1 commit into from
Mar 10, 2020

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Mar 9, 2020 •
edited
Loading

This reverts 619acd5 and re-lands 6cfa7fc. The 6cfa7fc was good. The screenshot changes were expected.

Fixes flutter/flutter#32215

@yjbanov yjbanov requested a review from cbracken March 9, 2020 22:20
@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 9, 2020

@cbracken what's the best way to make sure this does not break the framework? The shadow changes I'm making here are intentional, so whatever is breaking on the framework side we should probably update those tests.

@cbracken
Copy link
Member

cbracken commented Mar 9, 2020 •
edited
Loading

Once this is re-landed you'll need to monitor https://github.com/flutter/flutter/pulls for the engine roll that contains it and update the golden file screenshot tests. Keep in mind that the roll will be broken until the golden tests are updated.

@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 9, 2020

Ok, I'll try (I'm not sure how to monitor rolls and chime in in time before my change is reverted). Do you have a link to a previous roll that failed on my change that could look at?

@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 10, 2020

So I ran shadow_test.dart locally and verified that the shadow changes are as expected. I will merge this PR. In case I'm not in time to babysit the next engine roll, please just accept the golden changes during the roll.

@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 10, 2020

Merging on red. The redness is Fuchsia infra flakiness.

@yjbanov yjbanov merged commit d41e25b into flutter:master Mar 10, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
c03ef86 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
a298242 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
c6ff110 
)" (flutter#17008)" (flutter/engine#17040)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
3e31f0f 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
e593855 
)" (flutter#17008)" (flutter/engine#17040)
This was referenced Mar 10, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
638db33 
)" (flutter#17008)" (flutter/engine#17040)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
c2fe257 
)" (flutter#17008)" (flutter/engine#17040)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
da3a12e 
)" (flutter#17008)" (flutter/engine#17040)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
a685796 
)" (flutter#17008)" (flutter/engine#17040)
This was referenced Mar 11, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
70d9de1 
)" (flutter#17008)" (flutter/engine#17040)
@GaryQian
Copy link
Contributor

GaryQian commented Mar 11, 2020

I will be accepting the golden changes for the roll: goldens changes

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
743d5c3 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
dd4a5b1 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
d3122ba 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
85ad970 
)" (flutter#17008)" (flutter/engine#17040)
@yjbanov
Copy link
Contributor Author

yjbanov commented Mar 11, 2020

@GaryQian Sorry, I didn't see your message. I already triaged the golden changes for flutter/flutter#52410.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
32e3e1f 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020
@engine-flutter-autoroll
d41e25b Revert "Revert "fix shadows and mask filter blurs (flutter#16963
e5bb49d 
)" (flutter#17008)" (flutter/engine#17040)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 11, 2020
Closed
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits)
449aea9 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
@jason-simmons jason-simmons mentioned this pull request Mar 11, 2020
Merged
13 tasks
jason-simmons added a commit to flutter/flutter that referenced this pull request Mar 11, 2020
@jason-simmons
Manual roll engine 0e2c8fe..6d8611d (31 commits) (#52431)
5e74b00 
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087)
2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086)
2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084)
2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter/engine#17088)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082)
2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080)
2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079)
2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081)
2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450)
2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078)
2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072)
2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (#16960)" (flutter/engine#17074)
2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051)
2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069)
2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067)
2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994)
2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824)
2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040)
2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044)
2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995)
2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689)
2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020)
2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038)
2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960)
2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991)
2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033)
2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken Awaiting requested review from cbracken

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] Shadows on flutter_web not rendering like shadows in flutter

4 participants

@yjbanov @cbracken @GaryQian @googlebot