This repository was archived by the owner on Feb 25, 2025. It is now read-only.
In the test harness, don’t attempt to load AOT snapshots from non-existent dylibs. #16210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stent dylibs. This condition may arise when the embedder passes in a path to a non-existent dylib. Instead of crashing, the embedder will now return an error response. Fixes flutter/flutter#49732
cbracken
approved these changes
Jan 29, 2020
cbracken
reviewed
Jan 29, 2020
| namespace flutter { | ||
| namespace testing { | ||
|
|
||
| static constexpr const char* kAppAOTELFFileName = "app_elf_snapshot.so"; |
Member
There was a problem hiding this comment.
Isn't the const here redundant with constexpr?
Contributor
Author
There was a problem hiding this comment.
I wrote that on autopilot and was debating if it was redundant before you convinced me offline that that it was indeed unnecessary. When I changed it to remove the const though ISO C++11 does not allow conversion from string literal to 'char *const'.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 30, 2020
… non-existent dylibs. (flutter/engine#16210)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 30, 2020
… non-existent dylibs. (flutter/engine#16210)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 30, 2020
… non-existent dylibs. (flutter/engine#16210) (#49758) flutter/engine@6007c17...6061b80 git log 6007c17..6061b80 --first-parent --oneline 2020-01-29 chinmaygarde@google.com In the test harness, don’t attempt to load AOT snapshots from non-existent dylibs. (flutter/engine#16210) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
stuartmorgan-g
pushed a commit
to stuartmorgan-g/engine
that referenced
this pull request
Jan 30, 2020
…stent dylibs. (flutter#16210) This condition may arise when the embedder passes in a path to a non-existent dylib. Instead of crashing, the embedder will now return an error response. Fixes flutter/flutter#49732
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…stent dylibs. (flutter#16210) This condition may arise when the embedder passes in a path to a non-existent dylib. Instead of crashing, the embedder will now return an error response. Fixes flutter/flutter#49732
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
… non-existent dylibs. (flutter#16210)" This reverts commit 34e8604.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This condition may arise when the embedder passes in a path to a non-existent
dylib. Instead of crashing, the embedder will now return an error response.
Fixes flutter/flutter#49732