This repository was archived by the owner on Feb 25, 2025. It is now read-only.
retry on CIPD failure #15862
Merged
retry on CIPD failure #15862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jan 21, 2020
chinmaygarde
suggested changes
Jan 21, 2020
Contributor
chinmaygarde
left a comment
There was a problem hiding this comment.
Wait. Where is success used?
| except subprocess.CalledProcessError: | ||
| print('Failed %s times' % tries + 1) | ||
| if tries == num_tries - 1: | ||
| raise |
Contributor
There was a problem hiding this comment.
Maybe raise the actual exception?
Contributor
Author
There was a problem hiding this comment.
Got rid of the success part - that was an experiment I forgot to get rid of.
raise should just reraise AFAIK.
chinmaygarde
approved these changes
Jan 21, 2020
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 22, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 22, 2020
flutter/engine@79f898e...83a64b7 git log 79f898e..83a64b7 --first-parent --oneline 2020-01-22 dnfield@google.com derp (flutter/engine#15876) 2020-01-22 ferhat@gmail.com Implement Canvas drawPoints API for Html backend (flutter/engine#15870) 2020-01-22 dnfield@google.com retry on CIPD failure (flutter/engine#15862) 2020-01-21 skia-flutter-autoroll@skia.org Roll src/third_party/skia cedab522227a..4277f0173657 (9 commits) (flutter/engine#15863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
This reverts commit 98664d8.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry on CIPD failures, under the assumption that it's a timeout related to a backend failure.
fixes flutter/flutter#49240