This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add FML check to ensure layout before calling getters #15635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Jan 14, 2020
dnfield
reviewed
Jan 14, 2020
| } | ||
|
|
||
| double ParagraphTxt::GetAlphabeticBaseline() { | ||
| FML_DCHECK(!needs_layout_) << "only valid after layout"; |
Contributor
There was a problem hiding this comment.
I don't think these will fire on test runs for the framework - right?
Contributor
Author
There was a problem hiding this comment.
Does framework run any debug build tests? If not, should it? There are far more asserts in debug mode than the others and would catch more issues.
Contributor
Author
There was a problem hiding this comment.
Since these checks were not enforced before at this level, I was hesitant to add regular FML_CHECK as i feared it may cause apps to unexpectedly assert-crash.
Contributor
Author
There was a problem hiding this comment.
I think I'll land this first, and see if we can get a host_debug suite of test runs on framework.
Contributor
Author
|
Failure is a flake. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2020
This was referenced Jan 15, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 15, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 15, 2020
flutter/engine@ddaa9dc...bc41ab5 git log ddaa9dc..bc41ab5 --first-parent --oneline 2020-01-15 nurhan@google.com [web] Add Edge support for Flutter Engine unit-tests. (flutter/engine#15641) 2020-01-14 garyq@google.com Add FML_DCHECK to ensure layout before calling getters (flutter/engine#15635) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure the getters that depend on layout being performed are not being called before layout is performed. Part of hunt for lineMetrics flake flutter/flutter#43763