This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix platform view offsets incorrectly taking into account device pixel ratios. #14135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l ratios. This issue was hidden by an incorrect test expectation that has been corrected. Fixes b/144555069 Fixes flutter/flutter#45991
Contributor
Author
jason-simmons
approved these changes
Dec 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 4, 2019
…ice pixel ratios. (flutter/engine#14135)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
…ice pixel ratios. (flutter/engine#14135)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
…ice pixel ratios. (flutter/engine#14135)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
…ice pixel ratios. (flutter/engine#14135)
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
…l ratios. (flutter#14135) This issue was hidden by an incorrect test expectation that has been corrected. Fixes b/144555069 Fixes flutter/flutter#45991
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was hidden by an incorrect test expectation that has been corrected.
Fixes b/144555069
Fixes flutter/flutter#45991