Move Fuchsia unit test runners into engine repo #14092
Conversation
gw280
commented
Dec 3, 2019
- Copies fuchsia_test.sh into the testing/ directory
- Fixes a small issue with fuchsia_archive to ensure the cmx file is correctly named according to the target
- Add a list of fuchsia unittest fars to run on CI
- Add a GN build target to build all currently-enabled unittests for Fuchsia
|
Eventually I'd like to make the list of fuchsia fars autogenerated by gn at build time based off the fuchsia_tests target, but I wanted to keep the complexity down for this PR and iterate later. |
|
Is there a corresponding recipe change for this? Or is the plan to land this first and then do the recipe change? |
Yes, there's a corresponding recipe change which I have confirmed works on LUCI when I trigger manual runs with this branch (and it enables the fml_tests at the same time). I will upload the CL once this change is reviewed and merged as there will likely be recipe changes if anything needs changing in this CL (such as the file locations etc). |
iskakaushik
left a comment
There was a problem hiding this comment.
LGTM modulo the nits.
be08cef to
6bcc533
Compare
- Copies fuchsia_test.sh into the testing/fuchsia directory - Fixes a small issue with fuchsia_archive to ensure the cmx file is correctly named according to the target - Add a list of fuchsia unittest fars to run on CI - Add a GN build target to build all currently-enabled unittests for Fuchsia
489be10 to
06ef930
Compare
- Copies fuchsia_test.sh into the testing/fuchsia directory - Fixes a small issue with fuchsia_archive to ensure the cmx file is correctly named according to the target - Add a list of fuchsia unittest fars to run on CI - Add a GN build target to build all currently-enabled unittests for Fuchsia