This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Turn on RasterCache based on view hierarchy (#13360)" #13442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused EmbedderTest.VerifyB143464703 to fail after merging into
master.
```
../../flutter/shell/platform/embedder/tests/embedder_unittests.cc:3111: Failure
Value of: ImageMatchesFixture("verifyb143464703.png", renderered_scene)
Actual: false
Expected: true
[ FAILED ] EmbedderTest.VerifyB143464703 (2507 ms)
```
This reverts commit 3ad3bc7.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 30, 2019
git@github.com:flutter/engine.git/compare/5051bef17bdc...e609577 git log 5051bef..e609577 --no-merges --oneline 2019-10-30 mklim@google.com Revert "Turn on RasterCache based on view hierarchy (#13360)" (flutter/engine#13442) 2019-10-30 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13360) 2019-10-30 bkonyi@google.com Roll src/third_party/dart d3a5b82355..f30b494035 (9 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Contributor
|
The failure should have dumped both the expected image and actual image to disk and logged paths to the same. Can you attach the images to the the issue please? |
Contributor
Author
|
@chinmaygarde they should be there already, see flutter/flutter#38903 (comment). We should sync up to talk about this when you've got a minute, @liyuqian and I both suspect that this is an issue with the GL implementation in the test harness. The behavior doesn't repro on iOS and the visual degradation also doesn't appear to actually have to do with the cache. I could be missing something though. |
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/5051bef17bdc...e609577 git log 5051bef..e609577 --no-merges --oneline 2019-10-30 mklim@google.com Revert "Turn on RasterCache based on view hierarchy (flutter#13360)" (flutter/engine#13442) 2019-10-30 mklim@google.com Turn on RasterCache based on view hierarchy (flutter/engine#13360) 2019-10-30 bkonyi@google.com Roll src/third_party/dart d3a5b82355..f30b494035 (9 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused EmbedderTest.VerifyB143464703 to fail after merging into
master.
This reverts commit 3ad3bc7.
Opens flutter/flutter#38903.