This repository was archived by the owner on Feb 25, 2025. It is now read-only.
fix fml_unittes is not run during presubmit #13395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
approved these changes
Oct 28, 2019
Contributor
Author
|
It looks like the test 'TEST(MessageLoopTaskQueue, ConcurrentQueueAndTaskCreatingCounts)' |
e31f225 to
111dac7
Compare
chunhtai
commented
Oct 28, 2019
| created[queue_id - base_queue_id] = true; | ||
|
|
||
| for (int cur_q = 1; cur_q < i; cur_q++) { | ||
| if (created[cur_q - base_queue_id]) { |
Contributor
Author
There was a problem hiding this comment.
@iskakaushik I hope the fix is the intended behavior
cur_q - base_queue_id produce negative number which cause a inverted array lookup. I think this is not the intended behavior.
Contributor
There was a problem hiding this comment.
It does look suspicious as cur_q = 1, base_queue_id > 1 would make cur_q - base_queue_id negative easily. I wonder how Linux and Mac doesn't fail in this case?
Contributor
Author
There was a problem hiding this comment.
I think it depends on the compiler, some compiler let you access the index outside of boundary.
chunhtai
added a commit
to chunhtai/engine
that referenced
this pull request
Oct 29, 2019
This reverts commit 4d553cf.
chunhtai
added a commit
that referenced
this pull request
Oct 29, 2019
chunhtai
added a commit
to chunhtai/engine
that referenced
this pull request
Oct 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 30, 2019
git@github.com:flutter/engine.git/compare/36303c61b63f...5051bef git log 36303c6..5051bef --no-merges --oneline 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia ebdae1144978..7da048b5e8f1 (1 commits) (flutter/engine#13438) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from DfLN8... to p7XYM... (flutter/engine#13437) 2019-10-30 bkonyi@google.com Roll src/third_party/dart eb4ab61349..d3a5b82355 (4 commits) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from goLxs... to nhX22... (flutter/engine#13435) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia c3a51a5e47ba..ebdae1144978 (1 commits) (flutter/engine#13434) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1ae54bc22fc2..c3a51a5e47ba (1 commits) (flutter/engine#13433) 2019-10-30 bkonyi@google.com Roll src/third_party/dart ae5a86d790..eb4ab61349 (7 commits) 2019-10-30 dnfield@google.com Set the install name at link time for darwin dylibs (flutter/engine#13428) 2019-10-30 mehmetf@users.noreply.github.com Add isRunningInRobolectricTest back (flutter/engine#13424) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76d22d1ee8cb..1ae54bc22fc2 (26 commits) (flutter/engine#13430) 2019-10-30 bkonyi@google.com Roll src/third_party/dart ebd059030b..ae5a86d790 (3 commits) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/clang/linux-amd64 from Vghc_... to WxGHg... (flutter/engine#13420) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from mc3jR... to DfLN8... (flutter/engine#13413) 2019-10-30 bkonyi@google.com Roll src/third_party/dart 780af0fcfc..ebd059030b (17 commits) 2019-10-30 chinmaygarde@google.com Make sure root surface transformations survive resetting the matrix directly in Flow. (flutter/engine#13405) 2019-10-30 iska.kaushik@gmail.com [fuchsia] [packaging] Create a script to upload debug symbols to CIPD (flutter/engine#13422) 2019-10-29 47866232+chunhtai@users.noreply.github.com Revert "fix fml_unittes is not run during presubmit (#13395)" (flutter/engine#13425) 2019-10-29 30870216+gaaclarke@users.noreply.github.com Made it so we clean up gl resources when view controllers get deleted. (flutter/engine#13396) 2019-10-29 30870216+gaaclarke@users.noreply.github.com Added back in empty lifecycle events so we don't break people that used to call `super`. (flutter/engine#13421) 2019-10-29 47866232+chunhtai@users.noreply.github.com fix fml_unittes is not run during presubmit (flutter/engine#13395) 2019-10-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia f22dda960136..76d22d1ee8cb (2 commits) (flutter/engine#13411) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
chunhtai
added a commit
that referenced
this pull request
Oct 31, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/36303c61b63f...5051bef git log 36303c6..5051bef --no-merges --oneline 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia ebdae1144978..7da048b5e8f1 (1 commits) (flutter/engine#13438) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from DfLN8... to p7XYM... (flutter/engine#13437) 2019-10-30 bkonyi@google.com Roll src/third_party/dart eb4ab61349..d3a5b82355 (4 commits) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from goLxs... to nhX22... (flutter/engine#13435) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia c3a51a5e47ba..ebdae1144978 (1 commits) (flutter/engine#13434) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1ae54bc22fc2..c3a51a5e47ba (1 commits) (flutter/engine#13433) 2019-10-30 bkonyi@google.com Roll src/third_party/dart ae5a86d790..eb4ab61349 (7 commits) 2019-10-30 dnfield@google.com Set the install name at link time for darwin dylibs (flutter/engine#13428) 2019-10-30 mehmetf@users.noreply.github.com Add isRunningInRobolectricTest back (flutter/engine#13424) 2019-10-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia 76d22d1ee8cb..1ae54bc22fc2 (26 commits) (flutter/engine#13430) 2019-10-30 bkonyi@google.com Roll src/third_party/dart ebd059030b..ae5a86d790 (3 commits) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/clang/linux-amd64 from Vghc_... to WxGHg... (flutter/engine#13420) 2019-10-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from mc3jR... to DfLN8... (flutter/engine#13413) 2019-10-30 bkonyi@google.com Roll src/third_party/dart 780af0fcfc..ebd059030b (17 commits) 2019-10-30 chinmaygarde@google.com Make sure root surface transformations survive resetting the matrix directly in Flow. (flutter/engine#13405) 2019-10-30 iska.kaushik@gmail.com [fuchsia] [packaging] Create a script to upload debug symbols to CIPD (flutter/engine#13422) 2019-10-29 47866232+chunhtai@users.noreply.github.com Revert "fix fml_unittes is not run during presubmit (flutter#13395)" (flutter/engine#13425) 2019-10-29 30870216+gaaclarke@users.noreply.github.com Made it so we clean up gl resources when view controllers get deleted. (flutter/engine#13396) 2019-10-29 30870216+gaaclarke@users.noreply.github.com Added back in empty lifecycle events so we don't break people that used to call `super`. (flutter/engine#13421) 2019-10-29 47866232+chunhtai@users.noreply.github.com fix fml_unittes is not run during presubmit (flutter/engine#13395) 2019-10-29 skia-flutter-autoroll@skia.org Roll src/third_party/skia f22dda960136..76d22d1ee8cb (2 commits) (flutter/engine#13411) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC cbracken@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix test filter
flutter/flutter#42024