Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@iskakaushik
Copy link
Contributor

This is so we can connect to the timezone service.

This is so we can connect to the timezone service.
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Indent looks off in the diff.

LGTM stamp from a Japanese personal seal

@iskakaushik iskakaushik merged commit bfd7c1c into flutter:master Oct 4, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 4, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 7, 2019
git@github.com:flutter/engine.git/compare/7d90779bb66f...1d62160

git log 7d90779..1d62160 --no-merges --oneline
2019-10-04 iska.kaushik@gmail.com Prettify all CMX files (flutter/engine#12800)
2019-10-04 garyq@google.com Restart all modern Samsung keyboard IMM (flutter/engine#12780)
2019-10-04 dnfield@google.com Reland fuchsia build improvements (flutter/engine#12795)
2019-10-04 50856934+nturgut@users.noreply.github.com Fixing selection issues in Firefox (flutter/engine#12793)
2019-10-04 chinmaygarde@google.com Disable EmbedderTest::CanLaunchAndShutdownMultipleTimes. (flutter/engine#12799)
2019-10-04 iska.kaushik@gmail.com [flutter_runner] Update the cmx files to include TZ support (flutter/engine#12798)
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia fbdf48ecb204..95edac1c9a4a (1 commits) (flutter/engine#12790)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
git@github.com:flutter/engine.git/compare/7d90779bb66f...1d62160

git log 7d90779..1d62160 --no-merges --oneline
2019-10-04 iska.kaushik@gmail.com Prettify all CMX files (flutter/engine#12800)
2019-10-04 garyq@google.com Restart all modern Samsung keyboard IMM (flutter/engine#12780)
2019-10-04 dnfield@google.com Reland fuchsia build improvements (flutter/engine#12795)
2019-10-04 50856934+nturgut@users.noreply.github.com Fixing selection issues in Firefox (flutter/engine#12793)
2019-10-04 chinmaygarde@google.com Disable EmbedderTest::CanLaunchAndShutdownMultipleTimes. (flutter/engine#12799)
2019-10-04 iska.kaushik@gmail.com [flutter_runner] Update the cmx files to include TZ support (flutter/engine#12798)
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia fbdf48ecb204..95edac1c9a4a (1 commits) (flutter/engine#12790)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants