This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[flutter_runner] Explicitly set |trace_skia| to false #12349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly set |Application|'s |flutter::Settings| |trace_skia| field to false (it currently defaults to false), in order to slightly simplify the enabling skia trace events workflow. PT-145 #comment-patch Change-Id: Ib40f9ed3dc6f824056465db2cd45309c78b7e3b4
chinmaygarde
approved these changes
Sep 19, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 19, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 19, 2019
git@github.com:flutter/engine.git/compare/33ad6757e883...eed16d3 git log 33ad675..eed16d3 --no-merges --oneline 2019-09-19 iska.kaushik@gmail.com [flutter_runner] Explicitly set |trace_skia| to false (flutter/engine#12349) 2019-09-19 iska.kaushik@gmail.com [flutter_runner] Port the new compilation trace from topaz (flutter/engine#12348) 2019-09-19 iska.kaushik@gmail.com [flutter_runner][async] Migrate dart/flutter to new async-loop APIs (flutter/engine#12347) 2019-09-19 iska.kaushik@gmail.com [flutter_runner] Move from runner context to component context (flutter/engine#12346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
git@github.com:flutter/engine.git/compare/33ad6757e883...eed16d3 git log 33ad675..eed16d3 --no-merges --oneline 2019-09-19 iska.kaushik@gmail.com [flutter_runner] Explicitly set |trace_skia| to false (flutter/engine#12349) 2019-09-19 iska.kaushik@gmail.com [flutter_runner] Port the new compilation trace from topaz (flutter/engine#12348) 2019-09-19 iska.kaushik@gmail.com [flutter_runner][async] Migrate dart/flutter to new async-loop APIs (flutter/engine#12347) 2019-09-19 iska.kaushik@gmail.com [flutter_runner] Move from runner context to component context (flutter/engine#12346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set |Application|'s |flutter::Settings| |trace_skia| field to
false (it currently defaults to false), in order to slightly simplify
the enabling skia trace events workflow.
PT-145 #comment-patch
Change-Id: Ib40f9ed3dc6f824056465db2cd45309c78b7e3b4