This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add tracing of the number of frames in flight in the pipeline. #11423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 24, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 24, 2019
git@github.com:flutter/engine.git/compare/dfd281bcaefe...00b72a1 git log dfd281b..00b72a1 --no-merges --oneline 2019-08-23 50503328+flar@users.noreply.github.com Add tracing of the number of frames in flight in the pipeline. (flutter/engine#11423) 2019-08-23 dnfield@google.com Platform View implemenation for Metal (flutter/engine#11070) 2019-08-23 bkonyi@google.com Roll src/third_party/dart 2e4c89aa73..ef07c76302 (5 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot attached of the new tracing. You can see the depth counter go from 1 to 2 on the "Pipeline Depth" line of the graph when we fall behind by a frame. The exact value is shown in the sample window at the bottom.
