Update tflite_native and language_model revisions to match the Dart SDK #11230
Conversation
a-siva
left a comment
There was a problem hiding this comment.
Is there a way of auto detecting this dependency between the version of dart_tflite_native_rev and the dart sdk version so that this update is automatic when the script engine/src/tools/dart/create_updated_flutter_deps.py is run for every roll of Dart into Flutter.
I think @bkonyi or @aam would know. It needed to be added manually originally so I am just updating to latest Dart SDK versions. |
Once manually added, all dart-originated dependencies are automatically updated via https://github.com/flutter/buildroot/blob/master/tools/dart/create_updated_flutter_deps.py and normally don't have to be maintained manually in flutter/engine repo.
Unless there is some kind of emergency you normally want to wait for all checks to pass and get an approval before landing the change. |
|
@lambdabaa can you clarify why you had to do the updates and were not picked up automatically ? |
git@github.com:flutter/engine.git/compare/21ae92651a38...3e10d92 git log 21ae926..3e10d92 --no-merges --oneline 2019-08-19 bkonyi@google.com Roll src/third_party/dart 0e201edeeb..9f13d07670 (27 commits) 2019-08-19 matthew-carroll@users.noreply.github.com Notify framework to clear input connection when app is backgrounded (#35054) (flutter/engine#9498) 2019-08-19 dnfield@google.com Re-enable firebase test and don't use google login (flutter/engine#11228) 2019-08-19 ariaye@google.com Update tflite_native and language_model revisions to match the Dart SDK (flutter/engine#11230) 2019-08-19 skia-flutter-autoroll@skia.org Roll src/third_party/skia f8221786d088..8566dda51b42 (4 commits) (flutter/engine#11220) 2019-08-19 chinmaygarde@google.com Update metal layer drawable size on relayout. (flutter/engine#11224) 2019-08-19 dnfield@google.com Make firebase testlab always pass (flutter/engine#11226) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop the roller if necessary.
Sure, I saw that there were two references (in the |
Along with ensuring that the correct model is on Flutter master this should fix a number of incremental rebuild and permissions issues.